Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmark] actually set the env vars #12840

Merged
merged 1 commit into from
Apr 4, 2023
Merged

[benchmark] actually set the env vars #12840

merged 1 commit into from
Apr 4, 2023

Conversation

danking
Copy link
Contributor

@danking danking commented Apr 3, 2023

cc: @ehigham

@tpoterba
Copy link
Contributor

tpoterba commented Apr 3, 2023

oof

@danking
Copy link
Contributor Author

danking commented Apr 3, 2023

fwiw, j.env(VAR, VAL) is also available though that would set it for all the commands in the job.

@danking
Copy link
Contributor Author

danking commented Apr 3, 2023

(Also, I think you commented instead of approving)

@danking danking merged commit aa6a363 into main Apr 4, 2023
@daniel-goldstein daniel-goldstein deleted the danking-patch-6 branch April 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpoterba tpoterba tpoterba approved these changes

Assignees

@tpoterba tpoterba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danking @tpoterba